-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove settings and invoices internal endpoints #654
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #654 +/- ##
==========================================
- Coverage 91.58% 91.57% -0.02%
==========================================
Files 628 628
Lines 16705 16667 -38
==========================================
- Hits 15300 15262 -38
Misses 1405 1405
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #654 +/- ##
==========================================
- Coverage 91.58% 91.57% -0.02%
==========================================
Files 628 628
Lines 16705 16667 -38
==========================================
- Hits 15300 15262 -38
Misses 1405 1405
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #654 +/- ##
===========================================
Coverage 95.94000 95.94000
===========================================
Files 806 806
Lines 18022 17984 -38
===========================================
- Hits 17292 17254 -38
Misses 730 730
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Confirmed on profiler that these endpoints aren't being called anymore
Now that these endpoints have been migrated to GQL, remove unused internal endpoint code.
https://codecov.sentry.io/performance/summary/?environment=production&project=5215654&query=&referrer=performance-transaction-summary&statsPeriod=14d&transaction=%2Finternal%2F%7Bservice%7D%2F%7Bowner_username%7D%2Finvoices%2F&unselectedSeries=p100%28%29&unselectedSeries=avg%28%29
This closes codecov/engineering-team#1502
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.