Fix call to commit_components to use the right type
#660
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #660 +/- ##
===========================================
Coverage 95.94000 95.94000
===========================================
Files 799 799
Lines 17896 17902 +6
===========================================
+ Hits 17170 17176 +6
Misses 726 726
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #660 +/- ##
=======================================
Coverage 91.54% 91.55%
=======================================
Files 621 621
Lines 16579 16585 +6
=======================================
+ Hits 15178 15184 +6
Misses 1401 1401
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #660 +/- ##
=======================================
Coverage 91.54% 91.55%
=======================================
Files 621 621
Lines 16579 16585 +6
=======================================
+ Hits 15178 15184 +6
Misses 1401 1401
Flags with carried forward coverage won't be shown. Click here to find out more.
|
michelletran-codecov
force-pushed
the
452_fix_commit_components_api
branch
3 times, most recently
from
7c5ec47 to
fed4300
Compare
It was originally passing in a `User` object, but actually needed an `Owner` object. Getting the commit was (silently) failing on `service not found` because a service is not associated with a `User`. I tested this locally and it seems to get the YAML components for the commit now. Previously, it would default to the repo YAML, which would be unstable based on whether the repo YAML is set (or updated during sync).
This is because the `owner` doesn't _actually_ have to exist for the sequence of code to work. So, updating this on the reality.
michelletran-codecov
force-pushed
the
452_fix_commit_components_api
branch
from
fed4300 to
e4503f7
Compare
michelletran-codecov
temporarily deployed
to
staging
GitHub Actions
Inactive
Purpose/Motivation
Fix call to
commit_componentsto use theOwnertypeLinks to relevant tickets
https://github.com/codecov/internal-issues/issues/452
What does this PR do?
It was originally passing in a
Userobject, but actually needed anOwnerobject. Getting the commit was (silently) failing onservice not foundbecause a service is not associated with aUser.I tested this locally and it seems to get the YAML components for the commit now. Previously, it would default to the repo YAML, which would be unstable based on whether the repo YAML is set (or updated during sync).
I also added a log so that this shouldn't silently fail.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.