Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create mutation endpoint for OKTA config #661

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Conversation

RulaKhaled
Copy link
Contributor

Purpose/Motivation

What is the feature? Why is this being done?
We need to be able to send requests to update / create okta config in the DB

Links to relevant tickets

codecov/engineering-team#1981

What does this PR do?

Include a brief description of the changes in this PR. Bullet points are your friend.

  • New mutation
  • Tests

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@RulaKhaled RulaKhaled requested a review from a team as a code owner July 5, 2024 09:47
@codecov-staging
Copy link

codecov-staging bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 4 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files Patch % Lines
...uth/commands/owner/interactors/save_okta_config.py 89.74% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.56%. Comparing base (2261c6d) to head (c5c7ee4).

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main     #661      +/-   ##
==========================================
+ Coverage   91.54%   91.56%   +0.01%     
==========================================
  Files         621      624       +3     
  Lines       16579    16653      +74     
==========================================
+ Hits        15178    15248      +70     
- Misses       1401     1405       +4     
Flag Coverage Δ
unit 91.56% <94.59%> (+0.01%) ⬆️
unit-latest-uploader 91.56% <94.59%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov_auth/commands/owner/owner.py 100.00% <100.00%> (ø)
codecov_auth/tests/factories.py 100.00% <100.00%> (ø)
graphql_api/types/mutation/__init__.py 100.00% <100.00%> (ø)
graphql_api/types/mutation/mutation.py 100.00% <100.00%> (ø)
...ql_api/types/mutation/save_okta_config/__init__.py 100.00% <100.00%> (ø)
...ypes/mutation/save_okta_config/save_okta_config.py 100.00% <100.00%> (ø)
...uth/commands/owner/interactors/save_okta_config.py 89.74% <89.74%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.93%. Comparing base (2261c6d) to head (c5c7ee4).

✅ All tests successful. No failed tests found.

Files Patch % Lines
...uth/commands/owner/interactors/save_okta_config.py 89.74% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##               main       #661        +/-   ##
================================================
- Coverage   95.94000   95.93000   -0.01000     
================================================
  Files           799        802         +3     
  Lines         17896      17970        +74     
================================================
+ Hits          17170      17240        +70     
- Misses          726        730         +4     
Flag Coverage Δ
unit 91.56% <94.59%> (+0.01%) ⬆️
unit-latest-uploader 91.56% <94.59%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 91.56%. Comparing base (2261c6d) to head (c5c7ee4).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #661      +/-   ##
==========================================
+ Coverage   91.54%   91.56%   +0.01%     
==========================================
  Files         621      624       +3     
  Lines       16579    16653      +74     
==========================================
+ Hits        15178    15248      +70     
- Misses       1401     1405       +4     
Flag Coverage Δ
unit 91.56% <94.59%> (+0.01%) ⬆️
unit-latest-uploader 91.56% <94.59%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov_auth/commands/owner/owner.py 100.00% <100.00%> (ø)
codecov_auth/tests/factories.py 100.00% <100.00%> (ø)
graphql_api/types/mutation/__init__.py 100.00% <100.00%> (ø)
graphql_api/types/mutation/mutation.py 100.00% <100.00%> (ø)
...ql_api/types/mutation/save_okta_config/__init__.py 100.00% <100.00%> (ø)
...ypes/mutation/save_okta_config/save_okta_config.py 100.00% <100.00%> (ø)
...uth/commands/owner/interactors/save_okta_config.py 89.74% <89.74%> (ø)

Impacted file tree graph

assert okta_config.url is not None
assert okta_config.enabled == input_data["enabled"]
assert okta_config.enforced == input_data["enforced"]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra newlines

@RulaKhaled RulaKhaled added this pull request to the merge queue Jul 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 8, 2024
@RulaKhaled RulaKhaled added this pull request to the merge queue Jul 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 8, 2024
@RulaKhaled RulaKhaled added this pull request to the merge queue Jul 8, 2024
Merged via the queue into main with commit e9ec605 Jul 8, 2024
18 of 22 checks passed
@RulaKhaled RulaKhaled deleted the okta-mutation branch July 8, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants