-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create mutation endpoint for OKTA config #661
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #661 +/- ##
==========================================
+ Coverage 91.54% 91.56% +0.01%
==========================================
Files 621 624 +3
Lines 16579 16653 +74
==========================================
+ Hits 15178 15248 +70
- Misses 1401 1405 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #661 +/- ##
================================================
- Coverage 95.94000 95.93000 -0.01000
================================================
Files 799 802 +3
Lines 17896 17970 +74
================================================
+ Hits 17170 17240 +70
- Misses 726 730 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #661 +/- ##
==========================================
+ Coverage 91.54% 91.56% +0.01%
==========================================
Files 621 624 +3
Lines 16579 16653 +74
==========================================
+ Hits 15178 15248 +70
- Misses 1401 1405 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
assert okta_config.url is not None | ||
assert okta_config.enabled == input_data["enabled"] | ||
assert okta_config.enforced == input_data["enforced"] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: extra newlines
Purpose/Motivation
What is the feature? Why is this being done?
We need to be able to send requests to update / create okta config in the DB
Links to relevant tickets
codecov/engineering-team#1981
What does this PR do?
Include a brief description of the changes in this PR. Bullet points are your friend.
Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.