-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove session expiry cookie #662
fix: Remove session expiry cookie #662
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #662 +/- ##
==========================================
- Coverage 91.54% 91.54% -0.01%
==========================================
Files 621 621
Lines 16579 16573 -6
==========================================
- Hits 15178 15172 -6
Misses 1401 1401
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #662 +/- ##
==========================================
- Coverage 91.54% 91.54% -0.01%
==========================================
Files 621 621
Lines 16579 16573 -6
==========================================
- Hits 15178 15172 -6
Misses 1401 1401
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #662 +/- ##
===========================================
Coverage 95.94000 95.94000
===========================================
Files 799 799
Lines 17896 17890 -6
===========================================
- Hits 17170 17164 -6
Misses 726 726
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Removes the code that sets the github session expiry cookie.
We are going to try a different approach to come in a future PR.
Closes codecov/engineering-team#2025