Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove session expiry cookie #662

Merged

Conversation

spalmurray-codecov
Copy link
Contributor

Removes the code that sets the github session expiry cookie.

We are going to try a different approach to come in a future PR.

Closes codecov/engineering-team#2025

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review July 5, 2024 19:40
@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.54%. Comparing base (2261c6d) to head (65720ed).

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main     #662      +/-   ##
==========================================
- Coverage   91.54%   91.54%   -0.01%     
==========================================
  Files         621      621              
  Lines       16579    16573       -6     
==========================================
- Hits        15178    15172       -6     
  Misses       1401     1401              
Flag Coverage Δ
unit 91.54% <ø> (-0.01%) ⬇️
unit-latest-uploader 91.54% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov_auth/views/github.py 98.07% <ø> (-0.11%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.54%. Comparing base (2261c6d) to head (65720ed).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #662      +/-   ##
==========================================
- Coverage   91.54%   91.54%   -0.01%     
==========================================
  Files         621      621              
  Lines       16579    16573       -6     
==========================================
- Hits        15178    15172       -6     
  Misses       1401     1401              
Flag Coverage Δ
unit 91.54% <ø> (-0.01%) ⬇️
unit-latest-uploader 91.54% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov_auth/views/github.py 98.07% <ø> (-0.11%) ⬇️

Impacted file tree graph

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (2261c6d) to head (65720ed).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##               main       #662   +/-   ##
===========================================
  Coverage   95.94000   95.94000           
===========================================
  Files           799        799           
  Lines         17896      17890    -6     
===========================================
- Hits          17170      17164    -6     
  Misses          726        726           
Flag Coverage Δ
unit 91.54% <ø> (-0.01%) ⬇️
unit-latest-uploader 91.54% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit 68719c3 Jul 9, 2024
21 of 22 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/remove-gh-session-expiry-cookie branch July 9, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove session expiry tracker in Gazebo
2 participants