Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle analysis: measurements optional "after" data and fetch asset gzip size from DB #663

Merged
merged 6 commits into from
Jul 9, 2024

Conversation

JerrySentry
Copy link
Contributor

@JerrySentry JerrySentry commented Jul 5, 2024

  • Make the after arg as optional, if not present will fetch from the first commit measurement datapoint.
  • BundleAsset.bundleData.size.gzip now returns true gzip size if available (via version 2 of bundle stats file) or fallbacks to old calculation (ie size/1000)

closes codecov/engineering-team#1928

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@JerrySentry JerrySentry requested a review from a team as a code owner July 5, 2024 20:00
@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.58%. Comparing base (30a9b98) to head (da95d7e).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #663   +/-   ##
=======================================
  Coverage   91.58%   91.58%           
=======================================
  Files         628      628           
  Lines       16698    16705    +7     
=======================================
+ Hits        15293    15300    +7     
  Misses       1405     1405           
Flag Coverage Δ
unit 91.58% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.58% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/actions/measurements.py 100.00% <100.00%> (ø)
graphql_api/types/bundle_analysis/base.py 100.00% <100.00%> (ø)
services/bundle_analysis.py 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

codecov-public-qa bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.58%. Comparing base (30a9b98) to head (da95d7e).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #663   +/-   ##
=======================================
  Coverage   91.58%   91.58%           
=======================================
  Files         628      628           
  Lines       16698    16705    +7     
=======================================
+ Hits        15293    15300    +7     
  Misses       1405     1405           
Flag Coverage Δ
unit 91.58% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.58% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/actions/measurements.py 100.00% <100.00%> (ø)
graphql_api/types/bundle_analysis/base.py 100.00% <100.00%> (ø)
services/bundle_analysis.py 100.00% <100.00%> (ø)

Impacted file tree graph

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (30a9b98) to head (da95d7e).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##               main       #663   +/-   ##
===========================================
  Coverage   95.94000   95.94000           
===========================================
  Files           806        806           
  Lines         18015      18022    +7     
===========================================
+ Hits          17285      17292    +7     
  Misses          730        730           
Flag Coverage Δ
unit 91.58% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.58% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JerrySentry JerrySentry changed the title bundle analysis: measurements optional after date bundle analysis: measurements optional "after" data and fetch asset gzip size from DB Jul 8, 2024
@JerrySentry JerrySentry added this pull request to the merge queue Jul 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 9, 2024
@JerrySentry JerrySentry added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit f86ca8d Jul 9, 2024
21 of 22 checks passed
@JerrySentry JerrySentry deleted the jul_04_cache_1 branch July 9, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API] Call the shared gzipSize function and return it
2 participants