Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix un-formatted code + revert change to Owner Factory #665

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

nora-codecov
Copy link
Contributor

Purpose/Motivation

remember to run make lint 👍

@nora-codecov nora-codecov requested a review from a team as a code owner July 8, 2024 19:20
@nora-codecov nora-codecov enabled auto-merge July 8, 2024 19:34
@codecov-staging
Copy link

codecov-staging bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.58%. Comparing base (e9ec605) to head (f40597b).

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main     #665      +/-   ##
==========================================
- Coverage   91.58%   91.58%   -0.01%     
==========================================
  Files         628      628              
  Lines       16699    16698       -1     
==========================================
- Hits        15294    15293       -1     
  Misses       1405     1405              
Flag Coverage Δ
unit 91.58% <ø> (-0.01%) ⬇️
unit-latest-uploader 91.58% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...uth/commands/owner/interactors/save_okta_config.py 89.74% <ø> (ø)
codecov_auth/tests/factories.py 100.00% <ø> (ø)
...ypes/mutation/save_okta_config/save_okta_config.py 100.00% <ø> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

codecov-public-qa bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.58%. Comparing base (e9ec605) to head (f40597b).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #665      +/-   ##
==========================================
- Coverage   91.58%   91.58%   -0.01%     
==========================================
  Files         628      628              
  Lines       16699    16698       -1     
==========================================
- Hits        15294    15293       -1     
  Misses       1405     1405              
Flag Coverage Δ
unit 91.58% <ø> (-0.01%) ⬇️
unit-latest-uploader 91.58% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...uth/commands/owner/interactors/save_okta_config.py 89.74% <ø> (ø)
codecov_auth/tests/factories.py 100.00% <ø> (ø)
...ypes/mutation/save_okta_config/save_okta_config.py 100.00% <ø> (ø)

Impacted file tree graph

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (e9ec605) to head (f40597b).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##               main       #665   +/-   ##
===========================================
  Coverage   95.94000   95.94000           
===========================================
  Files           806        806           
  Lines         18016      18015    -1     
===========================================
- Hits          17286      17285    -1     
  Misses          730        730           
Flag Coverage Δ
unit 91.58% <ø> (-0.01%) ⬇️
unit-latest-uploader 91.58% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nora-codecov nora-codecov added this pull request to the merge queue Jul 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 8, 2024
@nora-codecov nora-codecov requested a review from a team as a code owner July 8, 2024 20:35
@nora-codecov nora-codecov changed the title fix un-formatted code fix un-formatted code + revert change to Owner Factory Jul 8, 2024
@nora-codecov nora-codecov added this pull request to the merge queue Jul 8, 2024
Merged via the queue into main with commit 4f74318 Jul 8, 2024
21 of 22 checks passed
@nora-codecov nora-codecov deleted the formatting branch July 8, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants