Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused code #676

Merged
merged 1 commit into from
Jul 11, 2024
Merged

remove unused code #676

merged 1 commit into from
Jul 11, 2024

Conversation

nora-codecov
Copy link
Contributor

Purpose/Motivation

Found some old code that's no longer in use while I was looking into webhooks and how we set them up.
I checked with application team and it seems like they aren't using the _reset_webhook endpoint.
All of the functionality to set up webhooks now lives on worker. And it looks like we don't have a delete_webhook anymore.

@codecov-qa
Copy link

codecov-qa bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.58%. Comparing base (769ed11) to head (f8ddeac).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #676   +/-   ##
=======================================
  Coverage   91.57%   91.58%           
=======================================
  Files         628      627    -1     
  Lines       16671    16641   -30     
=======================================
- Hits        15266    15240   -26     
+ Misses       1405     1401    -4     
Flag Coverage Δ
unit 91.58% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.58% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/internal/repo/views.py 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.58%. Comparing base (769ed11) to head (f8ddeac).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #676   +/-   ##
=======================================
  Coverage   91.57%   91.58%           
=======================================
  Files         628      627    -1     
  Lines       16671    16641   -30     
=======================================
- Hits        15266    15240   -26     
+ Misses       1405     1401    -4     
Flag Coverage Δ
unit 91.58% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.58% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/internal/repo/views.py 100.00% <100.00%> (ø)

Impacted file tree graph

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.93%. Comparing base (769ed11) to head (f8ddeac).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@               Coverage Diff                @@
##               main       #676        +/-   ##
================================================
- Coverage   95.94000   95.93000   -0.01000     
================================================
  Files           806        806                
  Lines         17988      17973        -15     
================================================
- Hits          17258      17243        -15     
  Misses          730        730                
Flag Coverage Δ
unit 91.58% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.58% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nora-codecov nora-codecov added this pull request to the merge queue Jul 11, 2024
Merged via the queue into main with commit ec5df79 Jul 11, 2024
21 of 22 checks passed
@nora-codecov nora-codecov deleted the nora/366 branch July 11, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants