Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update settings-base CSP #690

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Update settings-base CSP #690

merged 1 commit into from
Jul 18, 2024

Conversation

RulaKhaled
Copy link
Contributor

Purpose/Motivation

What is the feature? Why is this being done?

Links to relevant tickets

What does this PR do?

Include a brief description of the changes in this PR. Bullet points are your friend.

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.60%. Comparing base (8ce83e6) to head (e616437).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #690   +/-   ##
=======================================
  Coverage   91.60%   91.60%           
=======================================
  Files         628      628           
  Lines       16718    16718           
=======================================
  Hits        15315    15315           
  Misses       1403     1403           
Flag Coverage Δ
unit 91.60% <ø> (ø)
unit-latest-uploader 91.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov/settings_base.py 84.94% <ø> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.60%. Comparing base (8ce83e6) to head (e616437).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #690   +/-   ##
=======================================
  Coverage   91.60%   91.60%           
=======================================
  Files         628      628           
  Lines       16718    16718           
=======================================
  Hits        15315    15315           
  Misses       1403     1403           
Flag Coverage Δ
unit 91.60% <ø> (ø)
unit-latest-uploader 91.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov/settings_base.py 84.94% <ø> (ø)

Impacted file tree graph

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.95%. Comparing base (8ce83e6) to head (e616437).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##               main       #690   +/-   ##
===========================================
  Coverage   95.95000   95.95000           
===========================================
  Files           808        808           
  Lines         18055      18055           
===========================================
  Hits          17325      17325           
  Misses          730        730           
Flag Coverage Δ
unit 91.60% <ø> (ø)
unit-latest-uploader 91.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RulaKhaled RulaKhaled added this pull request to the merge queue Jul 18, 2024
Merged via the queue into main with commit d211946 Jul 18, 2024
21 of 22 checks passed
@RulaKhaled RulaKhaled deleted the fix-CSP branch July 18, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants