109 adjust sentry upload metrics #699
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #699 +/- ##
=======================================
Coverage 91.60% 91.61%
=======================================
Files 631 631
Lines 16841 16846 +5
=======================================
+ Hits 15428 15433 +5
Misses 1413 1413
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #699 +/- ##
=======================================
Coverage 91.60% 91.61%
=======================================
Files 631 631
Lines 16841 16846 +5
=======================================
+ Hits 15428 15433 +5
Misses 1413 1413
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #699 +/- ##
===========================================
Coverage 95.97000 95.97000
===========================================
Files 811 811
Lines 18178 18183 +5
===========================================
+ Hits 17446 17451 +5
Misses 732 732
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I'm adding/adjusting some metrics in the main api upload endpoints to track how often they're called with respect to shelter. Shelter already tracks these as well, https://github.com/codecov/shelter/blob/32f04439fb0d88d0a621f153993f1f264bb29102/upload-ingress/main.py#L41, so you can use Sentry's metrics tab to compare the amount request each gets. This PR is to add a call at the beginning of the call itself and then adjust the current one to represent the "end" of the part we're tracking
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.