-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Fix duplicate key value violates unique constraint "owner_service_ids" Sentry errors #705
[fix] Fix duplicate key value violates unique constraint "owner_service_ids" Sentry errors #705
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: webhook_handlers/views/github.py
Did you find this useful? React with a 👍 or 👎 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #705 +/- ##
=======================================
Coverage 91.65% 91.65%
=======================================
Files 632 632
Lines 16917 16917
=======================================
Hits 15506 15506
Misses 1411 1411
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #705 +/- ##
=======================================
Coverage 91.65% 91.65%
=======================================
Files 632 632
Lines 16917 16917
=======================================
Hits 15506 15506
Misses 1411 1411
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #705 +/- ##
===========================================
Coverage 95.98000 95.98000
===========================================
Files 812 812
Lines 18254 18254
===========================================
Hits 17522 17522
Misses 732 732
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Purpose/Motivation
This PR closes https://github.com/codecov/internal-issues/issues/493
We query for an owner during webhook events using
get_or_create
based on their service, service_id, and username. The combination of service and service_id serves as a unique key. We have cases where we have entries in the users table with no username so theget
part of theget_or_create
would returnNone
and thecreate
part attempts to create a new entry but fails due to violating the constraint. This change moves the username field to be a default argument.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.