Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version to legacy metrics #717

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

adrian-codecov
Copy link
Contributor

Purpose/Motivation

The legacy endpoint takes on reports from different versions, v2/3/4. We're trying to compare the in/out traffic from shelter and api, but shelter only supports (and only means to) v4, so we want to add another tag to filter v4 requests

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@adrian-codecov adrian-codecov requested a review from a team as a code owner July 29, 2024 21:15
@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.72%. Comparing base (acf1708) to head (a51e716).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #717   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files         632      632           
  Lines       17052    17054    +2     
=======================================
+ Hits        15641    15643    +2     
  Misses       1411     1411           
Flag Coverage Δ
unit 91.72% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
upload/helpers.py 94.69% <100.00%> (+0.03%) ⬆️
upload/views/legacy.py 95.07% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.72%. Comparing base (acf1708) to head (a51e716).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #717   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files         632      632           
  Lines       17052    17054    +2     
=======================================
+ Hits        15641    15643    +2     
  Misses       1411     1411           
Flag Coverage Δ
unit 91.72% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
upload/helpers.py 94.69% <100.00%> (+0.03%) ⬆️
upload/views/legacy.py 95.07% <100.00%> (ø)

Impacted file tree graph

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.02%. Comparing base (acf1708) to head (a51e716).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##               main       #717   +/-   ##
===========================================
  Coverage   96.02000   96.02000           
===========================================
  Files           814        814           
  Lines         18403      18405    +2     
===========================================
+ Hits          17671      17673    +2     
  Misses          732        732           
Flag Coverage Δ
unit 91.72% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrian-codecov adrian-codecov added this pull request to the merge queue Jul 29, 2024
Merged via the queue into main with commit 4665e0f Jul 29, 2024
21 of 22 checks passed
@adrian-codecov adrian-codecov deleted the legacy-add-version-to-sentry-metrics branch July 29, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants