Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test_results): graphql endpoint ordering bug #722

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

joseph-sentry
Copy link
Contributor

@joseph-sentry joseph-sentry commented Jul 30, 2024

There was a bug with the test results graphql endpoint that when ordering was set, the second page and onwards would be empty.

This was due to the need for part of the ordering parameter to have compeletely unique values due to how the CursorPagination class works.

Closes codecov/engineering-team#2168

There was a bug with the test results graphql endpoint that when
ordering was set, the second page and onwards would be empty.

This was due to the need for part of the ordering parameter to have
compeletely unique values due to how the CursorPagination class
works.
@joseph-sentry joseph-sentry requested a review from a team as a code owner July 30, 2024 18:30
@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.72%. Comparing base (e85b89e) to head (a89c63b).
Report is 8 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main     #722      +/-   ##
==========================================
+ Coverage   91.70%   91.72%   +0.01%     
==========================================
  Files         632      632              
  Lines       17014    17055      +41     
==========================================
+ Hits        15603    15644      +41     
  Misses       1411     1411              
Flag Coverage Δ
unit 91.72% <100.00%> (+0.01%) ⬆️
unit-latest-uploader 91.72% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/helpers/connection.py 96.82% <ø> (ø)
graphql_api/types/repository/repository.py 100.00% <ø> (ø)
graphql_api/types/test_results/test_results.py 100.00% <100.00%> (ø)
utils/test_results.py 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.72%. Comparing base (e85b89e) to head (a89c63b).
Report is 8 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #722      +/-   ##
==========================================
+ Coverage   91.70%   91.72%   +0.01%     
==========================================
  Files         632      632              
  Lines       17014    17055      +41     
==========================================
+ Hits        15603    15644      +41     
  Misses       1411     1411              
Flag Coverage Δ
unit 91.72% <100.00%> (+0.01%) ⬆️
unit-latest-uploader 91.72% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/helpers/connection.py 96.82% <ø> (ø)
graphql_api/types/repository/repository.py 100.00% <ø> (ø)
graphql_api/types/test_results/test_results.py 100.00% <100.00%> (ø)
utils/test_results.py 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

Impacted file tree graph

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.10%. Comparing base (e85b89e) to head (a89c63b).
Report is 10 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@               Coverage Diff                @@
##               main       #722        +/-   ##
================================================
+ Coverage   96.01000   96.10000   +0.09000     
================================================
  Files           814        814                
  Lines         18365      18749       +384     
================================================
+ Hits          17633      18018       +385     
+ Misses          732        731         -1     
Flag Coverage Δ
unit 91.72% <100.00%> (+0.01%) ⬆️
unit-latest-uploader 91.72% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joseph-sentry joseph-sentry added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit 183451b Jul 31, 2024
21 of 22 checks passed
@joseph-sentry joseph-sentry deleted the joseph/fix-test-results-gql branch July 31, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failed Tests] Fix Sorting Pagination Mechanism
2 participants