-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(test_results): graphql endpoint ordering bug #722
Conversation
There was a bug with the test results graphql endpoint that when ordering was set, the second page and onwards would be empty. This was due to the need for part of the ordering parameter to have compeletely unique values due to how the CursorPagination class works.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #722 +/- ##
==========================================
+ Coverage 91.70% 91.72% +0.01%
==========================================
Files 632 632
Lines 17014 17055 +41
==========================================
+ Hits 15603 15644 +41
Misses 1411 1411
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #722 +/- ##
==========================================
+ Coverage 91.70% 91.72% +0.01%
==========================================
Files 632 632
Lines 17014 17055 +41
==========================================
+ Hits 15603 15644 +41
Misses 1411 1411
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #722 +/- ##
================================================
+ Coverage 96.01000 96.10000 +0.09000
================================================
Files 814 814
Lines 18365 18749 +384
================================================
+ Hits 17633 18018 +385
+ Misses 732 731 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a bug with the test results graphql endpoint that when ordering was set, the second page and onwards would be empty.
This was due to the need for part of the ordering parameter to have compeletely unique values due to how the CursorPagination class works.
Closes codecov/engineering-team#2168