Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

further OwnerAdmin refinement #723

Merged
merged 5 commits into from
Aug 1, 2024
Merged

further OwnerAdmin refinement #723

merged 5 commits into from
Aug 1, 2024

Conversation

nora-codecov
Copy link
Contributor

Purpose/Motivation

minor changes to improve use for the Owner Admin

@nora-codecov nora-codecov requested a review from a team July 30, 2024 18:52
@codecov-qa
Copy link

codecov-qa bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.74%. Comparing base (183451b) to head (9bf3b14).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #723   +/-   ##
=======================================
  Coverage   91.73%   91.74%           
=======================================
  Files         632      632           
  Lines       17056    17073   +17     
=======================================
+ Hits        15646    15663   +17     
  Misses       1410     1410           
Flag Coverage Δ
unit 91.74% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.74% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov_auth/admin.py 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov-public-qa bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.74%. Comparing base (183451b) to head (9bf3b14).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #723   +/-   ##
=======================================
  Coverage   91.73%   91.74%           
=======================================
  Files         632      632           
  Lines       17056    17073   +17     
=======================================
+ Hits        15646    15663   +17     
  Misses       1410     1410           
Flag Coverage Δ
unit 91.74% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.74% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov_auth/admin.py 100.00% <100.00%> (ø)

Impacted file tree graph

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.03%. Comparing base (183451b) to head (9bf3b14).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@               Coverage Diff                @@
##               main       #723        +/-   ##
================================================
+ Coverage   96.02000   96.03000   +0.01000     
================================================
  Files           814        814                
  Lines         18407      18424        +17     
================================================
+ Hits          17676      17693        +17     
  Misses          731        731                
Flag Coverage Δ
unit 91.74% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.74% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nora-codecov nora-codecov force-pushed the nora/2060-3 branch 2 times, most recently from be8f2b3 to c2fd771 Compare July 31, 2024 00:00
@nora-codecov nora-codecov added this pull request to the merge queue Aug 1, 2024
Merged via the queue into main with commit 3ef41b6 Aug 1, 2024
19 of 20 checks passed
@nora-codecov nora-codecov deleted the nora/2060-3 branch August 1, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants