Sync account when creating in Okta #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelletran-codecov
temporarily deployed
to
staging
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #729 +/- ##
================================================
+ Coverage 96.02000 96.05000 +0.03000
================================================
Files 814 814
Lines 18453 18469 +16
================================================
+ Hits 17720 17740 +20
+ Misses 733 729 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
michelletran-codecov
requested review from
RulaKhaled,
nora-codecov and
a team
and removed request for
RulaKhaled and
nora-codecov
nora-codecov
approved these changes
Aug 2, 2024
michelletran-codecov
force-pushed
the
okta_lazy_account_creation_sync_account
branch
2 times, most recently
from
2cb92f7 to
28562be
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
This just syncs a bunch of other fields for accounts created during the Okta settings creation process.
michelletran-codecov
force-pushed
the
okta_lazy_account_creation_sync_account
branch
from
28562be to
8f2ba1d
Compare
michelletran-codecov
temporarily deployed
to
staging
GitHub Actions
Inactive
michelletran-codecov
deleted the
okta_lazy_account_creation_sync_account
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
This just syncs a bunch of other fields for accounts created during the Okta settings creation process so that the account objects make more sense.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.