Remove obsolete cleanup from BundleAnalysis
#731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #731 +/- ##
===========================================
Coverage 96.02000 96.02000
===========================================
Files 814 814
Lines 18453 18443 -10
===========================================
- Hits 17720 17710 -10
Misses 733 733
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Swatinem
force-pushed
the
swatinem/rm-cleanup
branch
from
cd4048e to
cd35b22
Compare
nora-codecov
approved these changes
Aug 5, 2024
The `shared` code completely removed the `db_session` on the `BundleAnalysisReport`. Thus there is no need to `close` those sessions and for these cleanup methods to exist.
Swatinem
force-pushed
the
swatinem/rm-cleanup
branch
from
d058341 to
a2d0e8c
Compare
matt-codecov
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
The
sharedcode completely removed thedb_sessionon theBundleAnalysisReport. Thus there is no need toclosethose sessions and for these cleanup methods to exist.Links to relevant tickets
related to https://github.com/codecov/internal-issues/issues/650
Notes to Reviewer
Depends on codecov/shared#309