fix: Default height/width to 100% if either doesn't exist #733
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
Fixes sentry issue: https://codecov.sentry.io/issues/2768942613/?environment=epic&environment=dd&environment=enova&environment=mailchimp&environment=production&environment=roblox&environment=snowflake&environment=prodvana&project=5514400&project=5215654&query=is%3Aunresolved+issue.priority%3A%5Bhigh%2C+medium%5D&referrer=issue-stream&statsPeriod=7d&stream_index=9
We just want to default a numerical value in the event both the .get() and the default from the get are non-integer values.
The sentry issue is complaining that the default value is '', and if you do '' or 100 (like in the PR), we will use 100
These eventually bubble up to here:
codecov-api/graphs/helpers/graph_utils.py
Lines 102 to 117 in c9bc2c8
Links to relevant tickets
Closes codecov/engineering-team#2204
Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.