fix: Add validation for trial start/cancel for user in calling org #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #736 +/- ##
================================================
+ Coverage 96.02000 96.04000 +0.02000
================================================
Files 814 814
Lines 18428 18543 +115
================================================
+ Hits 17695 17809 +114
- Misses 733 734 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RulaKhaled
reviewed
Aug 6, 2024
| from codecov.db import sync_to_async | ||
| from codecov_auth.helpers import current_user_part_of_org | ||
| from codecov_auth.models import Owner | ||
| from plan.service import PlanService | ||
|
|
||
|
|
||
| class StartTrialInteractor(BaseInteractor): |
There was a problem hiding this comment.
if we use this interactor in graphql fields, we probably can make use of the decorator @require_part_of_org
RulaKhaled
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
This PR aims to fix the IDOR hole mentioned in https://github.com/codecov/internal-issues/issues/646 where users can start or cancel trials even if they don't belong to the organization
To fix, we simply check to see that the user is part of the organization in the validate step prior to executing the mutation
Links to relevant tickets
Closes https://github.com/codecov/internal-issues/issues/646
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.