Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update DATA_UPLOAD_MAX_MEMORY_SIZE to 25 MB #740

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

ajay-sentry
Copy link
Contributor

@ajay-sentry ajay-sentry commented Aug 8, 2024

Purpose/Motivation

When looking through sentry issues, I saw one related to request body exceeding the max memory size, with ~800 events in the last 30 days. Looking at the stack trace, these all looked to be coming from the github webhook handler. Checking our current limit in API, it looks like our max size we currently allowed was set to 15MB; but then looking at the max github webhook size, they call out their size limit as 25MB. Anyone have any objections with increasing our max size allowed to 25MB to match with github? The value was set in API 4+ years ago and hasn't changed, it wouldn't surprise me if Github has increased their limits over time, but it also wouldn't surprise me if this was a design decision made purposefully either.

This PR updates the value to be 25MB, as well as updating the log for all webhook coming in from debug to info, so we can track roughly how many events we were dropping over time (pre/post)

Github webhooks are responsible for repository, owner, installations, commits, pulls, etc. so it's imperative that we don't drop any of these events if we can help it!

Sentry Issue -> mentions 6.6k events since we first noticed (March 2023)

Closes codecov/engineering-team#2235

References:

Links to relevant tickets

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.05%. Comparing base (2c80c02) to head (fff3b98).

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Files Patch % Lines
codecov/settings_prod.py 0.00% 1 Missing ⚠️
codecov/settings_staging.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##               main       #740   +/-   ##
===========================================
  Coverage   96.05000   96.05000           
===========================================
  Files           814        814           
  Lines         18469      18469           
===========================================
  Hits          17740      17740           
  Misses          729        729           
Flag Coverage Δ
unit 91.77% <33.33%> (ø)
unit-latest-uploader 91.77% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files Patch % Lines
codecov/settings_prod.py 0.00% 1 Missing ⚠️
codecov/settings_staging.py 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ajay-sentry ajay-sentry added this pull request to the merge queue Aug 8, 2024
Merged via the queue into main with commit c0110f8 Aug 8, 2024
15 of 18 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/update-max-mem-size branch August 8, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix for DATA_UPLOAD_MAX_MEMORY_SIZE, 15MB -> 25MB
2 participants