Add extra information to the impersonation logs #743
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #743 +/- ##
===========================================
Coverage 96.05000 96.05000
===========================================
Files 814 814
Lines 18469 18469
===========================================
Hits 17740 17740
Misses 729 729
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
michelletran-codecov
force-pushed
the
1850_add_more_impersonation_logs
branch
from
3516864 to
8063b0a
Compare
|
Update: Please do the following:
Thanks |
michelletran-codecov
force-pushed
the
1850_add_more_impersonation_logs
branch
from
8063b0a to
28981f6
Compare
In particular, we want to add the email and username for the staff user and the impersonated user. It is not easy to get the staff username, so only logging the staff email for now.
michelletran-codecov
force-pushed
the
1850_add_more_impersonation_logs
branch
from
28981f6 to
9c08519
Compare
|
I've removed the impersonating user information and am only adding the staff's email to the logged fields. The username is a bit tricky to get because it's service dependent (and requires another query). @jeff-a-holland-codecov |
|
Thanks, @michelletran-codecov ! |
| """Log and ensure that the impersonating user is authenticated. | ||
| The `current user` is the staff user that is impersonating the | ||
| user owner at `impersonating_ownerid`. | ||
| """ |
Purpose/Motivation
We want to improve impersonation logs for the security team.
Links to relevant tickets
codecov/engineering-team#1850
What does this PR do?
Adds extra email field for the staff user to the Panther impersonation logs.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.