Get app_redirect_url from owner object rather than request params #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #746 +/- ##
===========================================
Coverage 96.11000 96.11000
===========================================
Files 815 815
Lines 18449 18449
===========================================
Hits 17732 17732
Misses 717 717
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Swatinem
approved these changes
Aug 16, 2024
michelletran-codecov
force-pushed
the
645_fix_redirection_from_external_source
branch
from
754bf47 to
a8b3e93
Compare
This is to appease the static analysis security scan to ensure that we are not directly using user imput for redirect.
michelletran-codecov
force-pushed
the
645_fix_redirection_from_external_source
branch
from
a8b3e93 to
206ddfd
Compare
michelletran-codecov
deleted the
645_fix_redirection_from_external_source
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
This is to appease the static analysis security scan to ensure that we are not directly using user input for redirect.
Links to relevant tickets
https://github.com/codecov/internal-issues/issues/645
What does this PR do?
Change which username and service we're using to generate the app url.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.