update plan service to work with self-hosted and DEC #747
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
In CodeCov, every
Org
has aplan
, but if the customer is self-hosted or DEC, they also have alicense
.When an
Org
has alicense
, theplan_user_count
on theirOrg
is not accurate - the seat count is held by thenumber_allowed_users
field from thelicense
.Some self-hosted or DEC customers are getting a false positive on an alert that checks the seat count before allowing a user to view a repository, because the alert is using the
plan_user_count
field instead of thenumber_allowed_users
field from theirlicense
.Links to relevant tickets
https://github.com/codecov/internal-issues/issues/679
What does this PR do?
When checking
plan_user_count
inPlanService
, check for alicense
, and if they have alicense
, returnnumber_allowed_users
as the value forplan_user_count
. With this change, regular customers as well as self-hosted and DEC will get an accurate number back fromPlanService
- it will always return the paid seat count.