Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove session_totals field from report json #752

Merged
merged 1 commit into from
Aug 21, 2024
Merged

remove session_totals field from report json #752

merged 1 commit into from
Aug 21, 2024

Conversation

matt-codecov
Copy link
Contributor

@matt-codecov matt-codecov commented Aug 15, 2024

https://github.com/codecov/internal-issues/issues/515
codecov/shared#329

this field is bugged and, as far as i can tell, unused. see ticket + shared PR for details

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.16%. Comparing base (9aa6458) to head (c19cc8a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##               main       #752   +/-   ##
===========================================
  Coverage   96.16000   96.16000           
===========================================
  Files           814        814           
  Lines         18423      18423           
===========================================
  Hits          17716      17716           
  Misses          707        707           
Flag Coverage Δ
unit 91.91% <ø> (ø)
unit-latest-uploader 91.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always happy to see code go.
I guess the only real change here is in services/report.py which seems trivial?

@matt-codecov matt-codecov marked this pull request as ready for review August 20, 2024 21:24
@matt-codecov matt-codecov enabled auto-merge August 21, 2024 17:43
@matt-codecov matt-codecov added this pull request to the merge queue Aug 21, 2024
Merged via the queue into main with commit fc63977 Aug 21, 2024
17 of 18 checks passed
@matt-codecov matt-codecov deleted the pr752 branch August 21, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants