Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for trailing slashes #759

Merged
merged 1 commit into from
Aug 26, 2024
Merged

check for trailing slashes #759

merged 1 commit into from
Aug 26, 2024

Conversation

nora-codecov
Copy link
Contributor

Purpose/Motivation

When getting the enterprise url for oidc auth, remove trailing slashes if any exist

Links to relevant tickets

https://github.com/codecov/internal-issues/issues/702

@nora-codecov nora-codecov requested a review from a team August 16, 2024 23:11
@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.12%. Comparing base (a93299c) to head (20786bb).
Report is 14 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@               Coverage Diff                @@
##               main       #759        +/-   ##
================================================
+ Coverage   96.11000   96.12000   +0.01000     
================================================
  Files           815        815                
  Lines         18442      18443         +1     
================================================
+ Hits          17725      17729         +4     
+ Misses          717        714         -3     
Flag Coverage Δ
unit 91.87% <100.00%> (+0.01%) ⬆️
unit-latest-uploader 91.87% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nora-codecov nora-codecov added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit 615e4f3 Aug 26, 2024
17 of 18 checks passed
@nora-codecov nora-codecov deleted the nora/702 branch August 26, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants