feat: Add .mjs and .cjs to AssetType.JAVASCRIPT #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suejung-sentry
commented
Aug 23, 2024
requirements.in
Outdated
| @@ -20,7 +20,7 @@ factory-boy | |||
| fakeredis | |||
| freezegun | |||
| https://github.com/codecov/opentelem-python/archive/refs/tags/v0.0.4a1.tar.gz#egg=codecovopentelem | |||
| https://github.com/codecov/shared/archive/e944f586104a274032c7f547400f1cbcae3d4c7d.tar.gz#egg=shared | |||
| https://github.com/codecov/shared/TBD | |||
There was a problem hiding this comment.
depends on codecov/shared#335
JerrySentry
approved these changes
Aug 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #769 +/- ##
===========================================
Coverage 96.14000 96.14000
===========================================
Files 812 812
Lines 18423 18423
===========================================
Hits 17712 17712
Misses 711 711
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
Add additional file extensions to supported asset types in Bundle Analysis AssetReport. May cause step changes to stats as reports now count sizes of more files.
Paired with this PR: codecov/shared#335
Links to relevant tickets
Issue: codecov/engineering-team#2211