Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log repo signals #774

Merged
merged 2 commits into from
Aug 27, 2024
Merged

log repo signals #774

merged 2 commits into from
Aug 27, 2024

Conversation

adrian-codecov
Copy link
Contributor

@adrian-codecov adrian-codecov commented Aug 26, 2024

The token cacher is seemingly skipping some repositories getting saved in firestore. This is an attempt to log the start/error of any of these transactions to give me more visibility on the issue

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-notifications
Copy link

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files Patch % Lines
core/signals.py 84.61% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.14%. Comparing base (ae3f4d8) to head (8390413).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files Patch % Lines
core/signals.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##               main       #774        +/-   ##
================================================
- Coverage   96.15000   96.14000   -0.01000     
================================================
  Files           812        812                
  Lines         18416      18423         +7     
================================================
+ Hits          17707      17712         +5     
- Misses          709        711         +2     
Flag Coverage Δ
unit 91.96% <84.61%> (-0.01%) ⬇️
unit-latest-uploader 91.96% <84.61%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrian-codecov adrian-codecov added this pull request to the merge queue Aug 27, 2024
Merged via the queue into main with commit d038f2e Aug 27, 2024
15 of 18 checks passed
@adrian-codecov adrian-codecov deleted the 524-shelter-add-logs-to-signals branch August 27, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants