Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soft ripping out PreProcessUpload task #775

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

giovanni-guidini
Copy link
Contributor

Purpose/Motivation

What is the feature? Why is this being done?

Links to relevant tickets

What does this PR do?

Include a brief description of the changes in this PR. Bullet points are your friend.

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@giovanni-guidini giovanni-guidini requested a review from a team as a code owner August 27, 2024 12:50
Copy link
Contributor

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm I guess 🤷🏻‍♂️

@codecov-staging
Copy link

codecov-staging bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Aug 27, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2256 1 2255 6
View the top 1 failed tests by shortest run time
api.internal.tests.test_charts.TestOrganizationChartHandler test_basic_success
Stack Traces | 0.407s run time
self = <tests.test_charts.TestOrganizationChartHandler testMethod=test_basic_success>

    def test_basic_success(self):
        response = self._get(
            kwargs={"owner_username": self.org.username, "service": self.org.service},
            data={
                "grouping_unit": "day",
                "repositories": [self.repo1.name, self.repo2.name],
            },
        )
    
        assert response.status_code == 200
        assert len(response.data["coverage"]) == 1
>       assert response.data["coverage"][0]["total_hits"] == 114
E       AssertionError: assert Decimal('14') == 114

.../internal/tests/test_charts.py:995: AssertionError

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Copy link

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 2262 tests with 1 failed, 2255 passed and 6 skipped.

View the full list of failed tests

pytest

  • Class name: api.internal.tests.test_charts.TestOrganizationChartHandler
    Test name: test_basic_success

    self = <tests.test_charts.TestOrganizationChartHandler testMethod=test_basic_success>

    def test_basic_success(self):
    response = self._get(
    kwargs={"owner_username": self.org.username, "service": self.org.service},
    data={
    "grouping_unit": "day",
    "repositories": [self.repo1.name, self.repo2.name],
    },
    )

    assert response.status_code == 200
    assert len(response.data["coverage"]) == 1
    > assert response.data["coverage"][0]["total_hits"] == 114
    E AssertionError: assert Decimal('14') == 114

    .../internal/tests/test_charts.py:995: AssertionError

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.14%. Comparing base (80d64ad) to head (8dbc42f).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@               Coverage Diff                @@
##               main       #775        +/-   ##
================================================
+ Coverage   96.13000   96.14000   +0.01000     
================================================
  Files           812        812                
  Lines         18385      18388         +3     
================================================
+ Hits          17675      17679         +4     
+ Misses          710        709         -1     
Flag Coverage Δ
unit 91.96% <100.00%> (+0.02%) ⬆️
unit-latest-uploader 91.96% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giovanni-guidini giovanni-guidini added this pull request to the merge queue Aug 27, 2024
Merged via the queue into main with commit 6ef163d Aug 27, 2024
18 of 19 checks passed
@giovanni-guidini giovanni-guidini deleted the gio/test-remove-preprocessupload-task branch August 27, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants