Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plan service to work with Accounts #777

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Update plan service to work with Accounts #777

merged 1 commit into from
Aug 28, 2024

Conversation

nora-codecov
Copy link
Contributor

Purpose/Motivation

Gazebo uses PlanService to gate user actions, and can block a user from accessing private repos based on the has_seats_left property on the Org. Plan service is not aware of Accounts - we thought a user on a sales-led plan wouldn't interact with PlanService, that assumption was incorrect.

Links to relevant tickets

codecov/engineering-team#2268

What does this PR do?

Updates PlanService to check for presence of an Account then pull the numbers/settings from the Account rather than the Org for read-only purposes. still no write 🙃

@nora-codecov nora-codecov requested a review from a team August 28, 2024 00:22
@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.14%. Comparing base (d038f2e) to head (ac1eec8).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##               main       #777   +/-   ##
===========================================
  Coverage   96.14000   96.14000           
===========================================
  Files           812        812           
  Lines         18423      18430    +7     
===========================================
+ Hits          17712      17719    +7     
  Misses          711        711           
Flag Coverage Δ
unit 91.97% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.97% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nora-codecov nora-codecov added this pull request to the merge queue Aug 28, 2024
Merged via the queue into main with commit 66c7dd3 Aug 28, 2024
17 of 18 checks passed
@nora-codecov nora-codecov deleted the nora/2268 branch August 28, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants