Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: service arg being passed to test results upload task #779

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

joseph-sentry
Copy link
Contributor

it should be the ci_service request data param instead of the git_service that was previously being used.

fixes: codecov/codecov-cli#486

it should be the ci_service request data param instead of the
git_service that was previously being used.
@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.14%. Comparing base (d038f2e) to head (fcdebe3).
Report is 15 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##               main       #779   +/-   ##
===========================================
  Coverage   96.14000   96.14000           
===========================================
  Files           812        812           
  Lines         18423      18423           
===========================================
  Hits          17712      17712           
  Misses          711        711           
Flag Coverage Δ
unit 91.96% <100.00%> (ø)
unit-latest-uploader 91.96% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@adrian-codecov adrian-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Would you mind creating an issue for it in Shelter, https://github.com/codecov/shelter/issues, assign it to me and I'll get to it asap?

@joseph-sentry joseph-sentry added this pull request to the merge queue Sep 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 4, 2024
@joseph-sentry joseph-sentry added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit 99b57ef Sep 5, 2024
17 of 18 checks passed
@joseph-sentry joseph-sentry deleted the joseph/ci-service branch September 5, 2024 13:28
@webknjaz
Copy link

webknjaz commented Sep 5, 2024

@joseph-sentry is this getting deployed today? I've restarted one of the CI jobs and it's still happening so I assume it hasn't gone to prod just yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Uploading test results from GitHub Actions CI/CD fails (in some repos)
3 participants