Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2446 address rl bug #781

Merged
merged 2 commits into from
Aug 28, 2024
Merged

2446 address rl bug #781

merged 2 commits into from
Aug 28, 2024

Conversation

adrian-codecov
Copy link
Contributor

We're getting a bunch of errors in sentry regarding rate limits.

After looking at the logic, I believe it has to do with using the wrong owner in certain occasions. This PR addresses that.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@adrian-codecov adrian-codecov requested a review from a team as a code owner August 28, 2024 17:34
@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@adrian-codecov adrian-codecov added this pull request to the merge queue Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.14%. Comparing base (203bed5) to head (b085745).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##               main       #781   +/-   ##
===========================================
  Coverage   96.14000   96.14000           
===========================================
  Files           812        812           
  Lines         18423      18423           
===========================================
  Hits          17712      17712           
  Misses          711        711           
Flag Coverage Δ
unit 91.96% <100.00%> (ø)
unit-latest-uploader 91.96% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit ca403a1 Aug 28, 2024
17 of 18 checks passed
@adrian-codecov adrian-codecov deleted the 2446-address-rl-bug branch August 28, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants