fix: actually use history in aggregate_test_results #789
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #789 +/- ##
===========================================
Coverage 96.14000 96.14000
===========================================
Files 812 812
Lines 18486 18486
===========================================
Hits 17773 17773
Misses 713 713
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| dt.datetime.now(dt.UTC) - dt.timedelta(days=30) | ||
| if history is not None | ||
| else thirty_days_ago | ||
| (dt.datetime.now(dt.UTC) - history) if history is not None else thirty_days_ago |
There was a problem hiding this comment.
What values can history range from?
There was a problem hiding this comment.
i guess it could technically be anything if the caller to this function decides, as long as its a timedelta
There was a problem hiding this comment.
If this is going to leverage the partitions, I'd perhaps leave a comment noting the partition size and to be aware of preferred ranges 👌
No description provided.