Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add shared-change-checker CI step #797

Merged
merged 1 commit into from
Sep 5, 2024
Merged

add shared-change-checker CI step #797

merged 1 commit into from
Sep 5, 2024

Conversation

matt-codecov
Copy link
Contributor

@matt-codecov matt-codecov commented Sep 5, 2024

should automatically post/update a comment on PRs that change the hash of our shared dependency for reviewers to take a quick glance at

example comment (which was updated automatically as its PR switched to different hashes for shared):
Screenshot 2024-09-04 at 5 01 02 PM

@matt-codecov matt-codecov requested review from a team September 5, 2024 00:26
@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.14%. Comparing base (4b7e59a) to head (6afdee2).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##               main       #797   +/-   ##
===========================================
  Coverage   96.14000   96.14000           
===========================================
  Files           812        812           
  Lines         18483      18483           
===========================================
  Hits          17771      17771           
  Misses          712        712           
Flag Coverage Δ
unit 91.99% <ø> (ø)
unit-latest-uploader 91.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matt-codecov matt-codecov added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit b5b50c9 Sep 5, 2024
19 checks passed
@matt-codecov matt-codecov deleted the pr797 branch September 5, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants