[feat] Add AI features enabled resolvers #808

rohitvinnakota-codecov · 2024-09-09T15:35:42Z

We want to enable a new AI features tab on the UI, which exists at the org level. A Codecov user installs a separate AI features Github app on their org(on 1 or more repos).

Assuming webhooks are forwarded from the GH app, we should receive installation events in the api service.

The GithubAppInstallation model flow will be leveraged to create a new entry that references the app installation. This entry will have a reference to the owner that installed the app, and the app id of the AI features app. Note that ALL our app id entires in this table are the same(i.e. that of Codecov).

UI design here for folks who are interested: https://www.figma.com/design/hwKUPFyNRwGo5GGeWniHmb/GH-1661?node-id=2206-4584&t=vrlfUg43sgTLKuYv-4

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

codecov-staging · 2024-09-09T15:55:39Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

codecov-qa · 2024-09-09T15:55:45Z

❌ 2 Tests Failed:

Tests completed	Failed	Passed	Skipped
2276	2	2274	6

View the top 2 failed tests by shortest run time

graphql_api.tests.test_owner.TestOwnerType test_ai_features_enabled

Stack Traces | 0.377s run time

self = &lt;graphql_api.tests.test_owner.TestOwnerType testMethod=test_ai_features_enabled&gt;
get_config_mock = &lt;MagicMock name='get_config' id='139631388427136'&gt;

    @patch("services.self_hosted.get_config")
    def test_ai_features_enabled(self, get_config_mock):
        current_org = OwnerFactory(
            username="random-plan-user",
            service="github",
        )
    
        get_config_mock.return_value = [
            {"service": "github", "ai_features_app_id": 12345},
        ]
    
        ai_app_installation = GithubAppInstallation(
            name="ai-features",
            owner=current_org,
            repository_service_ids=None,
            installation_id=12345,
        )
    
        ai_app_installation.save()
    
        query = """{
            owner(username: "%s") {
                isAiFeaturesEnabled
            }
        }
    
        """ % (current_org.username)
    
&gt;       data = self.gql_request(query, owner=current_org)

graphql_api/tests/test_owner.py:880: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = &lt;graphql_api.tests.test_owner.TestOwnerType testMethod=test_ai_features_enabled&gt;
query = '{\n            owner(username: "random-plan-user") {\n                isAiFeaturesEnabled\n            }\n        }\n\n        '
provider = 'gh', owner = &lt;Owner: Owner&lt;github/random-plan-user&gt;&gt;
variables = None, with_errors = False, okta_signed_in_accounts = []
impersonate_owner = False

    def gql_request(
        self,
        query,
        provider="gh",
        owner=None,
        variables=None,
        with_errors=False,
        okta_signed_in_accounts=[],
        impersonate_owner=False,
    ):
        url = f"/graphql/{provider}"
    
        if owner:
            self.client = Client()
    
            if impersonate_owner:
                staff_owner = OwnerFactory(
                    name="staff_user", service="github", user=UserFactory(is_staff=True)
                )
                self.client.cookies = SimpleCookie({"staff_user": owner.pk})
                self.client.force_login_owner(staff_owner)
            else:
                self.client.force_login_owner(owner)
    
            if okta_signed_in_accounts:
                session = self.client.session
                session[OKTA_SIGNED_IN_ACCOUNTS_SESSION_KEY] = okta_signed_in_accounts
                session.save()
    
        response = self.client.post(
            url,
            {"query": query, "variables": variables or {}},
            content_type="application/json",
        )
&gt;       return response.json() if with_errors else response.json()["data"]
E       KeyError: 'data'

graphql_api/tests/helper.py:44: KeyError

graphql_api.tests.test_owner.TestOwnerType test_fetch_repos_ai_features_enabled

Stack Traces | 0.426s run time

self = &lt;graphql_api.tests.test_owner.TestOwnerType testMethod=test_fetch_repos_ai_features_enabled&gt;
get_config_mock = &lt;MagicMock name='get_config' id='139631385181984'&gt;

    @patch("services.self_hosted.get_config")
    def test_fetch_repos_ai_features_enabled(self, get_config_mock):
        current_org = OwnerFactory(
            username="random-plan-user",
            service="github",
        )
    
        get_config_mock.return_value = [
            {"service": "github", "ai_features_app_id": 12345},
        ]
    
        ai_app_installation = GithubAppInstallation(
            name="ai-features",
            owner=current_org,
            repository_service_ids=["repo-1"],
            installation_id=12345,
        )
    
        ai_app_installation.save()
    
        query = query_repositories % (
            self.owner.username,
            "(filters: { isAiFeaturesEnabled: true })",
            "",
        )
        data = self.gql_request(query, owner=current_org)
&gt;       repos = paginate_connection(data["owner"]["repositories"])
E       TypeError: 'NoneType' object is not subscriptable

graphql_api/tests/test_owner.py:909: TypeError

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

codecov-public-qa · 2024-09-09T15:55:49Z

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 2282 tests with 2 failed, 2274 passed and 6 skipped.

View the full list of failed tests

pytest

Class name: graphql_api.tests.test_owner.TestOwnerType
Test name: test_ai_features_enabled

self = <graphql_api.tests.test_owner.TestOwnerType testMethod=test_ai_features_enabled>
get_config_mock = <MagicMock name='get_config' id='139631388427136'>

    @patch("services.self_hosted.get_config")
    def test_ai_features_enabled(self, get_config_mock):
        current_org = OwnerFactory(
            username="random-plan-user",
            service="github",
        )
    
        get_config_mock.return_value = [
            {"service": "github", "ai_features_app_id": 12345},
        ]
    
        ai_app_installation = GithubAppInstallation(
            name="ai-features",
            owner=current_org,
            repository_service_ids=None,
            installation_id=12345,
        )
    
        ai_app_installation.save()
    
        query = """{
            owner(username: "%s") {
                isAiFeaturesEnabled
            }
        }
    
        """ % (current_org.username)
    
>       data = self.gql_request(query, owner=current_org)

graphql_api/tests/test_owner.py:880: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <graphql_api.tests.test_owner.TestOwnerType testMethod=test_ai_features_enabled>
query = '{\n            owner(username: "random-plan-user") {\n                isAiFeaturesEnabled\n            }\n        }\n\n        '
provider = 'gh', owner = <Owner: Owner<github/random-plan-user>>
variables = None, with_errors = False, okta_signed_in_accounts = []
impersonate_owner = False

    def gql_request(
        self,
        query,
        provider="gh",
        owner=None,
        variables=None,
        with_errors=False,
        okta_signed_in_accounts=[],
        impersonate_owner=False,
    ):
        url = f"/graphql/{provider}"
    
        if owner:
            self.client = Client()
    
            if impersonate_owner:
                staff_owner = OwnerFactory(
                    name="staff_user", service="github", user=UserFactory(is_staff=True)
                )
                self.client.cookies = SimpleCookie({"staff_user": owner.pk})
                self.client.force_login_owner(staff_owner)
            else:
                self.client.force_login_owner(owner)
    
            if okta_signed_in_accounts:
                session = self.client.session
                session[OKTA_SIGNED_IN_ACCOUNTS_SESSION_KEY] = okta_signed_in_accounts
                session.save()
    
        response = self.client.post(
            url,
            {"query": query, "variables": variables or {}},
            content_type="application/json",
        )
>       return response.json() if with_errors else response.json()["data"]
E       KeyError: 'data'

graphql_api/tests/helper.py:44: KeyError

Class name: graphql_api.tests.test_owner.TestOwnerType
Test name: test_fetch_repos_ai_features_enabled

self = <graphql_api.tests.test_owner.TestOwnerType testMethod=test_fetch_repos_ai_features_enabled>
get_config_mock = <MagicMock name='get_config' id='139631385181984'>

    @patch("services.self_hosted.get_config")
    def test_fetch_repos_ai_features_enabled(self, get_config_mock):
        current_org = OwnerFactory(
            username="random-plan-user",
            service="github",
        )
    
        get_config_mock.return_value = [
            {"service": "github", "ai_features_app_id": 12345},
        ]
    
        ai_app_installation = GithubAppInstallation(
            name="ai-features",
            owner=current_org,
            repository_service_ids=["repo-1"],
            installation_id=12345,
        )
    
        ai_app_installation.save()
    
        query = query_repositories % (
            self.owner.username,
            "(filters: { isAiFeaturesEnabled: true })",
            "",
        )
        data = self.gql_request(query, owner=current_org)
>       repos = paginate_connection(data["owner"]["repositories"])
E       TypeError: 'NoneType' object is not subscriptable

graphql_api/tests/test_owner.py:909: TypeError

codecov · 2024-09-09T15:57:15Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (52b7d30) to head (a546605).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@             Coverage Diff             @@
##               main       #808   +/-   ##
===========================================
  Coverage   96.23000   96.23000           
===========================================
  Files           812        812           
  Lines         18547      18566   +19     
===========================================
+ Hits          17848      17867   +19     
  Misses          699        699

Flag	Coverage Δ
unit	`92.46% <100.00%> (+<0.01%)`	⬆️
unit-latest-uploader	`92.46% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rohitvinnakota-codecov · 2024-09-10T17:10:57Z

@codecov-ai-reviewer

codecov-ai · 2024-09-10T17:13:07Z

graphql_api/types/owner/owner.py

+
+@owner_bindable.field("aiFeaturesEnabled")
+@require_part_of_org
+def resolve_ai_features_enabled(owner: Owner, info) -> bool | None:


The get_config function call should be moved outside of the resolver function to avoid fetching the configuration value on each call. This will improve performance by reducing redundant calls to the configuration service.

Suggested change

@owner_bindable.field("aiFeaturesEnabled")

@require_part_of_org

def resolve_ai_features_enabled(owner: Owner, info) -> bool | None:

ai_features_gh_app_id = get_config("github", "ai_features_app_id")

@owner_bindable.field("aiFeaturesEnabled")

@sync_to_async

@require_part_of_org

def resolve_ai_features_enabled(owner: Owner, info) -> bool:

return GithubAppInstallation.objects.filter(

app_id=ai_features_gh_app_id, owner=owner

).exists()

great thanks

Out of curiosity, what happens if I leave it as is?

…om/codecov/codecov-api into rvinnakota/add-ai-features-enabled

graphql_api/types/inputs/repository_set_filters.graphql

graphql_api/types/owner/owner.py

rohitvinnakota-codecov added 2 commits September 9, 2024 11:35

initial commit

6612a02

Lint

91a2e10

rohitvinnakota-codecov added 7 commits September 9, 2024 12:36

Fix

17cb6b5

Add tests first pass

2307921

Update

269eacf

Update tbd wording

216494d

Fix

7e4aa9d

Working tests

0cd2a25

More tests

b603f0a

rohitvinnakota-codecov changed the title ~~[draft] Add AI features enabled resolvers and webhook handlers~~ [feat] Add AI features enabled resolvers and webhook handlers Sep 10, 2024

rohitvinnakota-codecov marked this pull request as ready for review September 10, 2024 16:32

rohitvinnakota-codecov requested a review from a team as a code owner September 10, 2024 16:32

rohitvinnakota-codecov added 2 commits September 10, 2024 12:36

Update owner.graphql

6d03701

Update owner.py

cc340b4

codecov-ai bot reviewed Sep 10, 2024

View reviewed changes

rohitvinnakota-codecov added 3 commits September 10, 2024 13:28

Only fetch config once

9a265d2

Merge branch 'rvinnakota/add-ai-features-enabled' of https://github.c…

ea04ee3

…om/codecov/codecov-api into rvinnakota/add-ai-features-enabled

lint

7403bbd

JerrySentry reviewed Sep 10, 2024

View reviewed changes

graphql_api/types/inputs/repository_set_filters.graphql Outdated Show resolved Hide resolved

graphql_api/types/owner/owner.py Outdated Show resolved Hide resolved

rohitvinnakota-codecov and others added 4 commits September 10, 2024 15:04

Update repository_set_filters.graphql

4c926ea

Update owner.py

265a9ca

Lint

db6b920

Reformat

16dbbe2

codecov deleted a comment from ajay-sentry Sep 12, 2024

rohitvinnakota-codecov requested a review from JerrySentry September 12, 2024 16:26

JerrySentry approved these changes Sep 12, 2024

View reviewed changes

rohitvinnakota-codecov added 3 commits September 12, 2024 13:58

Merge branch 'main' into rvinnakota/add-ai-features-enabled

d411666

Merge branch 'main' into rvinnakota/add-ai-features-enabled

2efa8a5

Merge branch 'main' into rvinnakota/add-ai-features-enabled

a546605

rohitvinnakota-codecov changed the title ~~[feat] Add AI features enabled resolvers and webhook handlers~~ [feat] Add AI features enabled resolvers Sep 16, 2024

rohitvinnakota-codecov added this pull request to the merge queue Sep 16, 2024

Merged via the queue into main with commit bb6cc30 Sep 16, 2024
18 of 19 checks passed

rohitvinnakota-codecov deleted the rvinnakota/add-ai-features-enabled branch September 16, 2024 17:39

suejung-sentry pushed a commit that referenced this pull request Sep 30, 2024

[feat] Add AI features enabled resolvers (#808)

18ce75a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feat] Add AI features enabled resolvers #808

[feat] Add AI features enabled resolvers #808

rohitvinnakota-codecov commented Sep 9, 2024 •

edited

Loading

codecov-staging bot commented Sep 9, 2024 •

edited by codecov-notifications bot

Loading

codecov-qa bot commented Sep 9, 2024 •

edited

Loading

codecov-public-qa bot commented Sep 9, 2024 •

edited

Loading

pytest

codecov bot commented Sep 9, 2024 •

edited

Loading

rohitvinnakota-codecov commented Sep 10, 2024

codecov-ai bot Sep 10, 2024

rohitvinnakota-codecov Sep 10, 2024

rohitvinnakota-codecov Sep 11, 2024

-@owner_bindable.field("aiFeaturesEnabled")
-@require_part_of_org
-def resolve_ai_features_enabled(owner: Owner, info) -> bool | None:
+ai_features_gh_app_id = get_config("github", "ai_features_app_id")
+@owner_bindable.field("aiFeaturesEnabled")
+@sync_to_async
+@require_part_of_org
+def resolve_ai_features_enabled(owner: Owner, info) -> bool:
+    return GithubAppInstallation.objects.filter(
+        app_id=ai_features_gh_app_id, owner=owner
+    ).exists()

[feat] Add AI features enabled resolvers #808

[feat] Add AI features enabled resolvers #808

Conversation

rohitvinnakota-codecov commented Sep 9, 2024 • edited Loading

Legal Boilerplate

codecov-staging bot commented Sep 9, 2024 • edited by codecov-notifications bot Loading

Codecov Report

codecov-qa bot commented Sep 9, 2024 • edited Loading

❌ 2 Tests Failed:

codecov-public-qa bot commented Sep 9, 2024 • edited Loading

❌ Failed Test Results:

pytest

codecov bot commented Sep 9, 2024 • edited Loading

Codecov Report

rohitvinnakota-codecov commented Sep 10, 2024

codecov-ai bot Sep 10, 2024

Choose a reason for hiding this comment

rohitvinnakota-codecov Sep 10, 2024

Choose a reason for hiding this comment

rohitvinnakota-codecov Sep 11, 2024

Choose a reason for hiding this comment

rohitvinnakota-codecov commented Sep 9, 2024 •

edited

Loading

codecov-staging bot commented Sep 9, 2024 •

edited by codecov-notifications bot

Loading

codecov-qa bot commented Sep 9, 2024 •

edited

Loading

codecov-public-qa bot commented Sep 9, 2024 •

edited

Loading

codecov bot commented Sep 9, 2024 •

edited

Loading