Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Add a couple logs around gql rate limiter #809

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

ajay-sentry
Copy link
Contributor

Purpose/Motivation

Just adding a couple logs around the GQL rate limiter to better find the keys being used

What does this PR do?

Include a brief description of the changes in this PR. Bullet points are your friend.

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@ajay-sentry ajay-sentry requested a review from a team as a code owner September 9, 2024 18:18
@codecov-notifications
Copy link

codecov-notifications bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files Patch % Lines
graphql_api/views.py 66.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.14%. Comparing base (1b37195) to head (873cae2).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
graphql_api/views.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##               main       #809        +/-   ##
================================================
- Coverage   96.15000   96.14000   -0.01000     
================================================
  Files           812        812                
  Lines         18524      18527         +3     
================================================
+ Hits          17811      17813         +2     
- Misses          713        714         +1     
Flag Coverage Δ
unit 92.00% <66.66%> (-0.01%) ⬇️
unit-latest-uploader 92.00% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajay-sentry ajay-sentry added this pull request to the merge queue Sep 9, 2024
Merged via the queue into main with commit 4df7869 Sep 9, 2024
15 of 19 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/gql-rl-logs branch September 9, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants