Remove coverage offsets related code #822
Conversation
|
@codecov-ai-reviewer |
![codecov-ai[bot]](https://avatars.githubusercontent.com/in/797565?s=60&v=4){kind=small}
| @patch( | ||
| "services.comparison.PullRequestComparison.allow_coverage_offsets", | ||
| new_callable=PropertyMock, | ||
| ) | ||
| @patch( |
There was a problem hiding this comment.
The removal of the allow_coverage_offsets mock might affect the test if the functionality it mocks is still being used in the PullRequestComparison class. Ensure that this mock is no longer necessary.
There was a problem hiding this comment.
Can you explain more?
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #822 +/- ##
===========================================
Coverage 96.23000 96.23000
===========================================
Files 812 812
Lines 18552 18549 -3
===========================================
- Hits 17853 17850 -3
Misses 699 699
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
rohitvinnakota-codecov
deleted the
rvinnakota/remove-coverage-offsets
branch
Purpose/Motivation
What is the feature? Why is this being done?
Following up from #780, remove unused code pertaining to the old YAML field. This closes https://github.com/orgs/codecov/projects/31/views/11?pane=issue&itemId=77144226.
Links to relevant tickets
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.