Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove payment_behavior - it's breaking subscription.modify #839

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

nora-codecov
Copy link
Contributor

@nora-codecov nora-codecov commented Sep 26, 2024

Purpose/Motivation

Stripe errors are popping up in logs with this message StripeError raised: When payment_behavioris set topending_if_incomplete, you can only pass supported params. metadata is not supported. See https://stripe.com/docs/billing/subscriptions/pending-updates-reference#supported-attributes for more details.

There are several conflicting params, I'll have to sort them out later, for now removing this param from the .modify() call should fix the problem

Links to relevant tickets

codecov/engineering-team#2407
https://docs.stripe.com/billing/subscriptions/pending-updates-reference

@nora-codecov nora-codecov requested a review from a team September 26, 2024 01:59
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.25%. Comparing base (b2d3967) to head (e8cfc99).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##               main       #839   +/-   ##
===========================================
  Coverage   96.25000   96.25000           
===========================================
  Files           814        814           
  Lines         18656      18656           
===========================================
  Hits          17958      17958           
  Misses          698        698           
Flag Coverage Δ
unit 92.51% <ø> (ø)
unit-latest-uploader 92.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@nora-codecov nora-codecov added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit f203361 Sep 26, 2024
18 of 19 checks passed
@nora-codecov nora-codecov deleted the nora/2407 branch September 26, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants