remove payment_behavior - it's breaking subscription.modify #839
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
Stripe errors are popping up in logs with this message
StripeError raised: When
payment_behavioris set to
pending_if_incomplete, you can only pass supported params.
metadatais not supported. See https://stripe.com/docs/billing/subscriptions/pending-updates-reference#supported-attributes for more details.
There are several conflicting params, I'll have to sort them out later, for now removing this param from the .modify() call should fix the problem
Links to relevant tickets
codecov/engineering-team#2407
https://docs.stripe.com/billing/subscriptions/pending-updates-reference