Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update okta cloud views #841

Merged
merged 1 commit into from
Sep 27, 2024
Merged

update okta cloud views #841

merged 1 commit into from
Sep 27, 2024

Conversation

nora-codecov
Copy link
Contributor

Purpose/Motivation

Okta redirect wasn't working when users signed in through Sentry (instead of their git provider).

Links to relevant tickets

codecov/engineering-team#2349

What does this PR do?

Changes the way we check whether the user is logged in.

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.25%. Comparing base (f203361) to head (9d208e7).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #841   +/-   ##
=======================================
  Coverage   96.25%   96.25%           
=======================================
  Files         814      814           
  Lines       18656    18656           
=======================================
  Hits        17958    17958           
  Misses        698      698           
Flag Coverage Δ
unit 92.51% <100.00%> (ø)
unit-latest-uploader 92.51% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nora-codecov nora-codecov added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 2fca394 Sep 27, 2024
19 checks passed
@nora-codecov nora-codecov deleted the nora/2349 branch September 27, 2024 19:37
suejung-sentry pushed a commit that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants