-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add graphql coverage analytics - flags, components #842
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #842 +/- ##
==========================================
+ Coverage 96.28% 96.29% +0.01%
==========================================
Files 818 818
Lines 18818 18909 +91
==========================================
+ Hits 18118 18209 +91
Misses 700 700
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
3460a7b
to
659c1c2
Compare
86ec451
to
35ea43e
Compare
@@ -0,0 +1,784 @@ | |||
# TODO - delete this file with #2290 - tests have been ported over to new schema in test_flags.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed the existing file to _legacy.py
and we can delete this file once ready
edges { | ||
node { | ||
...FlagFragment | ||
coverageAnalytics { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file reflects the new flags related tests (existing tests are in the test_flags_legacy.py
file that will get deleted once ready)
@@ -0,0 +1,1389 @@ | |||
from unittest.mock import PropertyMock, patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file will get cleaned up with #2290
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a copy of the existing graphql_api/tests/test_components.py
original file
graphql_api/types/coverage_analytics/coverage_analytics.graphql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
My 2.1 PR also touches test_components.py but I think it should be separate enough that it doesn't think there are conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Thanks! I'll ping you to coordinate, if you want to go first! |
Description
This is another batch of fields to move over for the GraphQL restructure project.
It takes
flags
andcomponents
which are coverage related concepts and nests them within the newrepository.coverageAnalytics
type.Closes codecov/engineering-team#2284
Tested by confirming the unit tests when moved over pass as expected.
Also tested in staging that the apis return the expected data.
The duplicated behavior will get cleaned up with this ticket after frontend cutover done.
Summary of Changes
These were the updates to the schema:
BEFORE
AFTER
This is the GraphQL Query
example query variables
Screenshots from testing in staging that the same data is returned when querying with and without the new nesting level