Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Skip tests when deploying to staging #846

Closed
wants to merge 1 commit into from

Conversation

suejung-sentry
Copy link
Contributor

@suejung-sentry suejung-sentry commented Oct 1, 2024

The staging deploy takes a while, mostly due to the ~10min test runner (which can sometimes fail due to flaky tests, so maybe more than that including retries). This PR considers skipping that step for the staging deploy only so testing cycles on staging can be faster.

@suejung-sentry suejung-sentry changed the title chore: Skip tsts when deploying to staging chore: Skip tests when deploying to staging Oct 1, 2024
@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.26%. Comparing base (2fca394) to head (ce670f2).
Report is 128 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #846   +/-   ##
=======================================
  Coverage   96.26%   96.26%           
=======================================
  Files         814      814           
  Lines       18680    18680           
=======================================
  Hits        17982    17982           
  Misses        698      698           
Flag Coverage Δ
unit 92.52% <ø> (ø)
unit-latest-uploader 92.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@suejung-sentry suejung-sentry deleted the sshin/chore/staging branch December 1, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant