Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test #848

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix test #848

merged 1 commit into from
Oct 3, 2024

Conversation

nora-codecov
Copy link
Contributor

Purpose/Motivation

We don't need to be asserting on that value

@nora-codecov nora-codecov requested a review from a team October 1, 2024 22:13
@codecov-notifications
Copy link

codecov-notifications bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.25%. Comparing base (a4d04bc) to head (ef938a1).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #848   +/-   ##
=======================================
  Coverage   96.25%   96.25%           
=======================================
  Files         814      814           
  Lines       18659    18659           
=======================================
  Hits        17961    17961           
  Misses        698      698           
Flag Coverage Δ
unit 92.51% <ø> (ø)
unit-latest-uploader 92.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nora-codecov nora-codecov added this pull request to the merge queue Oct 3, 2024
Merged via the queue into main with commit a8cafca Oct 3, 2024
18 of 19 checks passed
@nora-codecov nora-codecov deleted the nora/fix-test-that-always-fails branch October 3, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants