Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add totalSeatCount resolver on Account #853

Merged
merged 5 commits into from
Oct 4, 2024

Conversation

spalmurray-codecov
Copy link
Contributor

Adds a resolver on Account to return totalSeatCount, which is the sum of plan seats and free seats.

Closes codecov/engineering-team#2556

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.28%. Comparing base (acf749e) to head (d45b9da).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #853   +/-   ##
=======================================
  Coverage   96.28%   96.28%           
=======================================
  Files         818      818           
  Lines       18818    18822    +4     
=======================================
+ Hits        18118    18122    +4     
  Misses        700      700           
Flag Coverage Δ
unit 92.57% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 92.57% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review October 3, 2024 19:31
@spalmurray-codecov spalmurray-codecov requested a review from a team as a code owner October 3, 2024 19:31
@spalmurray-codecov spalmurray-codecov force-pushed the spalmurray/account-total-seat-count branch from e315fe1 to d0a25ee Compare October 3, 2024 19:52
@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit d5a83aa Oct 4, 2024
19 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/account-total-seat-count branch October 4, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API] Implement totalSeatCount resolver on Account
3 participants