-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add history, fix percent_diff rounding and flake aggregate time #868
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time. ❌ Failed Test Results:Completed 2555 tests with View the full list of failed testspytest
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #868 +/- ##
==========================================
- Coverage 96.34% 96.29% -0.05%
==========================================
Files 823 823
Lines 19161 19187 +26
==========================================
+ Hits 18461 18477 +16
- Misses 700 710 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0e5a17e
to
c7bdcf1
Compare
a9821f8
to
780fc27
Compare
Gonna address @ajay-sentry's feedback on this PR:
this one is a bit confusing but the idea is that we want flakes that were active at some point during the time period starting at
|
- remove unnecessary convert_kwargs_to_snake_case decorator call
return await sync_to_async(generate_test_results_aggregates)( | ||
repoid=repository.repoid | ||
repoid=repository.repoid, history=history | ||
) | ||
|
||
|
||
@test_analytics_bindable.field("flakeAggregates") | ||
@convert_kwargs_to_snake_case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dont need these @convert_kwargs_to_snake_case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Ported changes from #857 with merge conflicts resolved