Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rollback last_duration query temporarily in order to help performance #872

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

joseph-sentry
Copy link
Contributor

No description provided.

@joseph-sentry joseph-sentry requested a review from a team as a code owner October 8, 2024 18:21
@codecov-staging
Copy link

codecov-staging bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Oct 8, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2568 1 2567 6
View the top 1 failed tests by shortest run time
graphql_api.tests.test_test_result_legacy.TestResultTestCase test_fetch_test_result_last_duration
Stack Traces | 0.41s run time
self = <graphql_api.tests.test_test_result_legacy.TestResultTestCase testMethod=test_fetch_test_result_last_duration>

    def test_fetch_test_result_last_duration(self) -> None:
        query = """
            query {
               owner(username: "%s") {
                    repository(name: "%s") {
                        ... on Repository {
                            testResults {
                                edges {
                                    node {
                                        lastDuration
                                    }
                                }
                            }
                        }
                    }
                 }
            }
        """ % (self.owner.username, self.repository.name)
    
        result = self.gql_request(query, owner=self.owner)
    
        assert "errors" not in result
>       assert (
            result["owner"]["repository"]["testResults"]["edges"][0]["node"][
                "lastDuration"
            ]
            == 5.0
        )
E       assert 0.0 == 5.0

graphql_api/tests/test_test_result_legacy.py:187: AssertionError

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Copy link

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 2574 tests with 1 failed, 2567 passed and 6 skipped.

View the full list of failed tests

pytest

  • Class name: graphql_api.tests.test_test_result_legacy.TestResultTestCase
    Test name: test_fetch_test_result_last_duration

    self = <graphql_api.tests.test_test_result_legacy.TestResultTestCase testMethod=test_fetch_test_result_last_duration>

    def test_fetch_test_result_last_duration(self) -> None:
    query = """
    query {
    owner(username: "%s") {
    repository(name: "%s") {
    ... on Repository {
    testResults {
    edges {
    node {
    lastDuration
    }
    }
    }
    }
    }
    }
    }
    """ % (self.owner.username, self.repository.name)

    result = self.gql_request(query, owner=self.owner)

    assert "errors" not in result
    > assert (
    result["owner"]["repository"]["testResults"]["edges"][0]["node"][
    "lastDuration"
    ]
    == 5.0
    )
    E assert 0.0 == 5.0

    graphql_api/tests/test_test_result_legacy.py:187: AssertionError

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.29%. Comparing base (f4a178c) to head (c910ad0).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #872      +/-   ##
==========================================
- Coverage   96.29%   96.29%   -0.01%     
==========================================
  Files         823      823              
  Lines       19187    19186       -1     
==========================================
- Hits        18477    18476       -1     
  Misses        710      710              
Flag Coverage Δ
unit 92.66% <ø> (-0.01%) ⬇️
unit-latest-uploader 92.66% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joseph-sentry joseph-sentry added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit 3c7cbc1 Oct 8, 2024
18 of 19 checks passed
@joseph-sentry joseph-sentry deleted the joseph/rollback-last-duration branch October 8, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants