Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update shared #877

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

update shared #877

wants to merge 2 commits into from

Conversation

adrian-codecov
Copy link
Contributor

Update shared to latest

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link
Contributor

github-actions bot commented Oct 9, 2024

This PR includes changes to shared. Please review them here: codecov/shared@88117b9...b9e83b2

@codecov-staging
Copy link

codecov-staging bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Oct 9, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
2569 2 2567 6
View the top 2 failed tests by shortest run time
services.tests.test_report.ReportServiceTest test_build_report_from_commit_with_flags
Stack Traces | 0.034s run time
self = <services.tests.test_report.ReportServiceTest testMethod=test_build_report_from_commit_with_flags>
read_chunks_mock = <MagicMock name='read_chunks' id='139824081424544'>

    @patch("services.archive.ArchiveService.read_chunks")
    def test_build_report_from_commit_with_flags(self, read_chunks_mock):
        f = open(current_file.parent / "samples" / "chunks.txt", "r")
        read_chunks_mock.return_value = f.read()
        commit = CommitWithReportFactory.create(message="aaaaa", commitid="abf6d4d")
        report = build_report_from_commit(commit)
        res = report.flags["integrations"].report
        assert len(res.report._chunks) == 3
        assert len(res.files) == 3
>       file_1, file_2, file_3 = sorted(res.file_reports(), key=lambda x: x.name)
E       AttributeError: 'FilteredReport' object has no attribute 'file_reports'

services/tests/test_report.py:216: AttributeError
services.tests.test_report.ReportServiceTest test_build_report_from_commit_with_non_carried_forward_flags
Stack Traces | 0.039s run time
self = <services.tests.test_report.ReportServiceTest testMethod=test_build_report_from_commit_with_non_carried_forward_flags>
read_chunks_mock = <MagicMock name='read_chunks' id='139824081004704'>

    @patch("services.archive.ArchiveService.read_chunks")
    def test_build_report_from_commit_with_non_carried_forward_flags(
        self, read_chunks_mock
    ):
        f = open(current_file.parent / "samples" / "chunks.txt", "r")
        read_chunks_mock.return_value = f.read()
        commit = CommitWithReportFactory.create(
            message="another test",
            commitid="asdfbhasdf89",
        )
        commit_report = commit.reports.first()
        session = commit_report.sessions.filter(order_number=1).first()
        session.upload_type = "carriedforward"
        session.upload_extras = {
            "carriedforward_from": "56e05fced214c44a37759efa2dfc25a65d8ae98d"
        }
        session.save()
    
        report = build_report_from_commit(commit)
        res = report.flags["integrations"].report
        assert len(res.report._chunks) == 3
        assert len(res.files) == 3
>       file_1, file_2, file_3 = sorted(res.file_reports(), key=lambda x: x.name)
E       AttributeError: 'FilteredReport' object has no attribute 'file_reports'

services/tests/test_report.py:248: AttributeError

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Copy link

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 2575 tests with 2 failed, 2567 passed and 6 skipped.

View the full list of failed tests

pytest

  • Class name: services.tests.test_report.ReportServiceTest
    Test name: test_build_report_from_commit_with_flags

    self = <services.tests.test_report.ReportServiceTest testMethod=test_build_report_from_commit_with_flags>
    read_chunks_mock = <MagicMock name='read_chunks' id='139824081424544'>

    @patch("services.archive.ArchiveService.read_chunks")
    def test_build_report_from_commit_with_flags(self, read_chunks_mock):
    f = open(current_file.parent / "samples" / "chunks.txt", "r")
    read_chunks_mock.return_value = f.read()
    commit = CommitWithReportFactory.create(message="aaaaa", commitid="abf6d4d")
    report = build_report_from_commit(commit)
    res = report.flags["integrations"].report
    assert len(res.report._chunks) == 3
    assert len(res.files) == 3
    > file_1, file_2, file_3 = sorted(res.file_reports(), key=lambda x: x.name)
    E AttributeError: 'FilteredReport' object has no attribute 'file_reports'

    services/tests/test_report.py:216: AttributeError
  • Class name: services.tests.test_report.ReportServiceTest
    Test name: test_build_report_from_commit_with_non_carried_forward_flags

    self = <services.tests.test_report.ReportServiceTest testMethod=test_build_report_from_commit_with_non_carried_forward_flags>
    read_chunks_mock = <MagicMock name='read_chunks' id='139824081004704'>

    @patch("services.archive.ArchiveService.read_chunks")
    def test_build_report_from_commit_with_non_carried_forward_flags(
    self, read_chunks_mock
    ):
    f = open(current_file.parent / "samples" / "chunks.txt", "r")
    read_chunks_mock.return_value = f.read()
    commit = CommitWithReportFactory.create(
    message="another test",
    commitid="asdfbhasdf89",
    )
    commit_report = commit.reports.first()
    session = commit_report.sessions.filter(order_number=1).first()
    session.upload_type = "carriedforward"
    session.upload_extras = {
    "carriedforward_from": "56e05fced214c44a37759efa2dfc25a65d8ae98d"
    }
    session.save()

    report = build_report_from_commit(commit)
    res = report.flags["integrations"].report
    assert len(res.report._chunks) == 3
    assert len(res.files) == 3
    > file_1, file_2, file_3 = sorted(res.file_reports(), key=lambda x: x.name)
    E AttributeError: 'FilteredReport' object has no attribute 'file_reports'

    services/tests/test_report.py:248: AttributeError

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.29%. Comparing base (d5ca070) to head (73c4af1).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #877   +/-   ##
=======================================
  Coverage   96.29%   96.29%           
=======================================
  Files         823      823           
  Lines       19185    19185           
=======================================
  Hits        18475    18475           
  Misses        710      710           
Flag Coverage Δ
unit 92.65% <ø> (-0.02%) ⬇️
unit-latest-uploader 92.65% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants