Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add totalFlakyFailCount to testResult #887

Merged
merged 7 commits into from
Oct 16, 2024

Conversation

joseph-sentry
Copy link
Contributor

No description provided.

if a test has a computed name we want to return that as the test name
in the GQL Test Result object instead of its uncomputed name
otherwise just return its uncomputed name with the special separation
character escaped
@joseph-sentry joseph-sentry requested a review from a team as a code owner October 15, 2024 16:19
@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.31%. Comparing base (8945e37) to head (1df9758).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #887   +/-   ##
=======================================
  Coverage   96.31%   96.31%           
=======================================
  Files         823      823           
  Lines       19079    19083    +4     
=======================================
+ Hits        18376    18380    +4     
  Misses        703      703           
Flag Coverage Δ
unit 92.66% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 92.66% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@joseph-sentry joseph-sentry added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 3c2b4ff Oct 16, 2024
19 checks passed
@joseph-sentry joseph-sentry deleted the joseph/add-total-flaky-failure-count branch October 16, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants