Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix TestFactory #889

Merged
merged 1 commit into from
Oct 23, 2024
Merged

test: fix TestFactory #889

merged 1 commit into from
Oct 23, 2024

Conversation

joseph-sentry
Copy link
Contributor

there is a shared change that will remove the commits_where_fail
field from the Test model so having the commits_where_fail field
be set in the TestFactory will cause tests to fail

there is a shared change that will remove the commits_where_fail
field from the Test model so having the commits_where_fail field
be set in the TestFactory will cause tests to fail
@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.31%. Comparing base (8945e37) to head (3ddfe75).
Report is 22 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #889      +/-   ##
==========================================
- Coverage   96.31%   96.31%   -0.01%     
==========================================
  Files         823      823              
  Lines       19079    19078       -1     
==========================================
- Hits        18376    18375       -1     
  Misses        703      703              
Flag Coverage Δ
unit 92.66% <ø> (-0.01%) ⬇️
unit-latest-uploader 92.66% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joseph-sentry joseph-sentry added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 4c7ffcc Oct 23, 2024
19 checks passed
@joseph-sentry joseph-sentry deleted the joseph/fix-factory branch October 23, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants