Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle analysis: sentry->prometheus metrics for upload view #899

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

JerrySentry
Copy link
Contributor

closes codecov/engineering-team#2654

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (3b84808) to head (d8de0bb).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #899   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files         823      823           
  Lines       19118    19119    +1     
=======================================
+ Hits        18415    18416    +1     
  Misses        703      703           
Flag Coverage Δ
unit 92.67% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 92.67% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@JerrySentry JerrySentry marked this pull request as ready for review October 17, 2024 14:31
@JerrySentry JerrySentry requested a review from a team as a code owner October 17, 2024 14:31
@JerrySentry JerrySentry added this pull request to the merge queue Oct 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 17, 2024
@JerrySentry JerrySentry added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit 3895811 Oct 17, 2024
19 checks passed
@JerrySentry JerrySentry deleted the oct_17_ba_prometheus branch October 17, 2024 20:29
JerrySentry added a commit that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundle Analysis: add Prometheus metrics for api upload
2 participants