fix: Remove ordering on account organizations list #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ee activatedUserCount on that account's orgs
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
ajay-sentry
reviewed
Oct 17, 2024
nora-codecov
approved these changes
Oct 17, 2024
| and current_user.is_authenticated | ||
| and queried_owner | ||
| and queried_owner.account | ||
| and current_user in queried_owner.account.users.all() |
There was a problem hiding this comment.
💯 💯 💯
LMK if this is being slow, can optimize with
- a prefetch for the Account and Users objs when you hit the db for the Owner obj
- doing
current_user in queried_owner.account.users.all()in a different way
There was a problem hiding this comment.
queried_owner is the OwnerOrg that the current_user is checking permissions for right? Not the current_user's OwnerUser object 🫠
There was a problem hiding this comment.
@nora-codecov Yes. Specifically this decorator should allow users to see fields on owners they share an account with. For example, I'm in codecov org and not sentry org. Since we share an Account, this decorator will let me see certain things on Sentry that an unrelated user could not see.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the ordering argument on the account organizations list because it turns out that the paginator can't handle/isn't intended to do sorting by count of a field. Was throwing errors.
Additionally, adds a new resolver decorator to allow users of an account to see the activatedUserCount of orgs in that same account. This was a necessary change to support the desired UI, otherwise we'd only show activated user counts for orgs that the user is a member of.