Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle analysis: prometheus metrics fix #903

Merged
merged 2 commits into from
Oct 17, 2024
Merged

bundle analysis: prometheus metrics fix #903

merged 2 commits into from
Oct 17, 2024

Conversation

JerrySentry
Copy link
Contributor

@JerrySentry JerrySentry commented Oct 17, 2024

remove the repo_visibility label as it is only available on 1 of the 2 metrics calls.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@JerrySentry JerrySentry marked this pull request as ready for review October 17, 2024 21:20
@JerrySentry JerrySentry requested a review from a team as a code owner October 17, 2024 21:20
@JerrySentry JerrySentry changed the title bundle analysis: prometheus metrics bundle analysis: prometheus metrics fix Oct 17, 2024
@JerrySentry JerrySentry enabled auto-merge October 17, 2024 21:26
@JerrySentry JerrySentry disabled auto-merge October 17, 2024 21:27
@JerrySentry JerrySentry enabled auto-merge October 17, 2024 21:33
@codecov-notifications
Copy link

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
upload/views/bundle_analysis.py 60.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@JerrySentry JerrySentry added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit 1203a60 Oct 17, 2024
15 of 19 checks passed
@JerrySentry JerrySentry deleted the oct_18_ba_2 branch October 17, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants