Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shared and remove statsd metrics usage #912

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

Swatinem
Copy link
Contributor

shared.metrics does not re-export statsd anymore.

`shared.metrics` does not re-export `statsd` anymore.
@Swatinem Swatinem requested a review from a team October 22, 2024 13:51
@Swatinem Swatinem self-assigned this Oct 22, 2024
@Swatinem Swatinem requested a review from a team as a code owner October 22, 2024 13:51
Copy link
Contributor

This PR includes changes to shared. Please review them here: codecov/shared@f0e213c...4e27927

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (f8ac094) to head (52dd85c).
Report is 8 commits behind head on main.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #912      +/-   ##
==========================================
- Coverage   96.25%   96.24%   -0.02%     
==========================================
  Files         823      823              
  Lines       18999    18950      -49     
==========================================
- Hits        18288    18238      -50     
- Misses        711      712       +1     
Flag Coverage Δ
unit 92.48% <100.00%> (-0.04%) ⬇️
unit-latest-uploader 92.48% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-staging
Copy link

codecov-staging bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Oct 22, 2024

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
3 3 0 0
View the top 3 failed tests by shortest run time
 upload.tests.test_upload
Stack Traces | 0s run time
No failure message available
 webhook_handlers.tests.test_github
Stack Traces | 0s run time
No failure message available
 webhook_handlers.tests.test_github_enterprise
Stack Traces | 0s run time
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Copy link

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 3 tests with 3 failed, 0 passed and 0 skipped.

View the full list of failed tests

pytest

  • Class name:
    Test name: upload.tests.test_upload

    No failure message available
  • Class name:
    Test name: webhook_handlers.tests.test_github

    No failure message available
  • Class name:
    Test name: webhook_handlers.tests.test_github_enterprise

    No failure message available

@Swatinem Swatinem enabled auto-merge October 24, 2024 10:35
@Swatinem Swatinem added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit 6bd632d Oct 24, 2024
16 of 19 checks passed
@Swatinem Swatinem deleted the swatinem/update-shared branch October 24, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants