Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generous amounts of tracing throughout the repo #916

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

JerrySentry
Copy link
Contributor

Preemptively add Sentry traces at likely/possible chokepoints so that when we have an issue to debug why things are slow it would increase the chances that we already have traces for it.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.80%. Comparing base (f8ac094) to head (83be7ff).
Report is 4 commits behind head on main.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #916      +/-   ##
==========================================
- Coverage   96.25%   95.80%   -0.46%     
==========================================
  Files         823      758      -65     
  Lines       18999    15277    -3722     
==========================================
- Hits        18288    14636    -3652     
+ Misses        711      641      -70     
Flag Coverage Δ
unit ?
unit-latest-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@JerrySentry JerrySentry marked this pull request as ready for review October 22, 2024 19:08
@JerrySentry JerrySentry requested a review from a team as a code owner October 22, 2024 19:08
@ajay-sentry ajay-sentry added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 3d8af18 Oct 23, 2024
17 of 19 checks passed
@ajay-sentry ajay-sentry deleted the oct_23_tracing branch October 23, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants